This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: make PLUS commutative by default


Mark Mitchell wrote:

This patch is OK if (a) nobody objects within 24 hours, and (b) you get an IA64 maintainer to confirm/deny that IA64 is non-commutative in the same way, and (c) you get someone to run the tests for you on PA (and IA64, if you need the special hook there), and (d) this comment:

+Usually, this is just COMMUTATIVE_P (@var{x}), but the pa doesn't consider

is changed to say "HP PA" instead of "pa".


John David Anglin wrote:


The builds were successful and no new regressions were noticed.


Thanks. I have checked in the patch now, with the comment change that Mark requested.

[pa_commutative_p]

The 32-bit linux runtime loads the same value in all space registers.
Thus, the default definition should work for this target.



It's TARGET_NO_SPACE_REGS that determines whether or not addition is commutative on HP PA.

I have checked in the original pa_commutative_p definition that was approved and
that you tested. You can now consider if you want to change
TARGET_COMMUTATIVE_P for the 32-bit linux configuration and/or add
a check of TARGET_NO_SPACE_REGS to pa_commutative_p.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]