This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: RFA: Fix java/18119
- From: Andrew Haley <aph at redhat dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 7 Jul 2005 12:16:43 +0100
- Subject: Re: Patch: RFA: Fix java/18119
- References: <42CC8F89.9090204@redhat.com>
Bryce McKinlay writes:
> When resolving an inner class, GCJ may encounter a class with the
> correct name but which is invisible due to accessibility. In this case,
> we need to continue following the resolution rules until the correct one
> is found, but keep any "candidate" - correct name but invisible -
> classes around in order to issue a useful error message. This patch does
> this, simplifying resolve_inner_class() somewhat and introducing
> inner_class_accessible() in order to test accessibility without issuing
> an error immediately.
>
> No testsuite regressions and 4 new JACKS passes. OK to commit?
>
> Bryce
>
> 2005-07-06 Bryce McKinlay <mckinlay@redhat.com>
>
> PR java/18119
> * parse.y (inner_class_accessible): New function. Logic moved from
> check_inner_class_access.
> (check_inner_class_access): Use inner_class_accessible.
> (resolve_inner_class): Simplify arguments. Create circularity hash
> here. Keep looking for classes if we found one that was inaccessible.
> Return the inaccessible class only if there is no other match.
> (do_resolve_class): Update for new resolve_inner_class arguments.
> Don't create circularity_hash here.
Yes, thanks.
Andrew.