Re: patch: morpho ms1-elf support

[Mark Mitchell <mark at codesourcery dot com>]

DJ Delorie wrote:
> > I agree in principle. However in my experience you can usually say
> > something meaningful about most target macros. eg.
>
>
> My opinion is that the "this is obvious" comments dilute the value of
> the other comments.  If *everything* has a comment of some sort, you
> lose the ability to pick out the important ones, and instead learn to
> filter them all out.

I think that this is clearly a low-order bit in overall GCC development. 
  I hesitate even to comment, in that I'm sure we could waste a lot of 
time arguing about it.

However, I've looked a lot of bits of GCC that did not have any 
comments, and there was nothing obvious about them.  I'd far rather see 
us err on the side of commenting, than in the other direction.

I certainly think that things like:

  #define FIXED_REGISTERS \
  { 1, /* Always zero */
    1, /* Stack pointer */
    ...
  }

are very helpful.  You probably agree, so this is probably not what you 
mean.

Anyhow, I agree with Joseph that I'd like to see the comments he's 
requested.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304