This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: morpho ms1-elf support


On Tue, 5 Jul 2005, Aldy Hernandez wrote:

> Here is a patch adding support for ms1-elf to GCC.  I have gzipped the
> patch cause it's 200k.

The files added have the old FSF address and references to "GNU CC".  
They also have lots of cut-and-paste comments from the internals manual 
(quite possibly from an old version thereof) which say nothing specific to 
this port.  There should be no need for an xm-ms1.h file; in general 
xm-*.h files are deprecated, and I don't think *-elf are GCC hosts anyway.  
lib2extra-funcs.c has no copyright and licence notice.  Likewise ABI.txt 
and t-ms1 (see <http://www.gnu.org/prep/maintain/maintain.html>: any file 
more than ten lines long should have such notices; the simple permissive 
notice

     Copying and distribution of this file, with or without modification,
     are permitted in any medium without royalty provided the copyright
     notice and this notice are preserved.

is probably the appropriate one for short rough documentation like 
ABI.txt).  ms1_handle_isr_attribute should use %qs instead of `%s'.  The 
documentation documents options which don't exist (there's no .opt file, 
so no target options).  The target attribute needs documenting in 
extend.texi.  Target constraints should be documented in md.texi.  See the 
checklist under "Back End" in sourcebuild.texi for other places which may 
need documenting.  ms1_debug_stack has an error message ending in ".", 
contrary to the GNU Coding Standards, and as it's followed by an abort 
internal_error would be the better function to call.  All calls to abort() 
should be gcc_assert or gcc_unreachable instead.  There are many functions 
in ms1.c without the necessary comment above them explaining what they do, 
the arguments and the return value (in some cases, "MS1 implementation of 
target macro FOO" may be sufficient comment, leaving it to the internals 
manual to detail the parameters and return value of that macro).  File 
names such as crti.o in the documentation should be enclosed in @file{}.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]