This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bad checkin/ChangeLog to toplev.c on 2005-03-31?


> The ChangeLog for
> 
> http://gcc.gnu.org/ml/gcc-cvs/2005-03/msg01487.html
> 
> has
> 
> 	* toplev.c (wrapup_global_declarations): Kill non-unit-at-a-time code.
> 	(check_global_declarations): Ifdef out code clearing DECL_RTL.
> 
> But there was no change to check_global_declarations at all. Is that
> a typo or some change is missing? I am trying to figure out how
It is somewhat inaccurate changelog (I concatenated it from the original
entries as it was developed on a branch and this change went away with
some unrelated cleanups during the progress and I failed to mention it
in changelog later).  Sorry for that.

> to fix a serious 4.0/4.1 regression:
> 
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21828
> 
> where debug info is omitted for uninitialized variables. It seems that
> check_global_declarations does the wrong thing on uninitialized
> variables.

Hmm, there are quite few nasty bits here.  I think you are right in the
bug audit trail that check_global_declarations should be reordred after
cgraph finalization as it checks TREE_ASM_WRITTEN flag that is clearly
not set in a way it expects.

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]