This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch Modified] re: Enable Hollerith constant and character arrayin format tag (take 3).


On Monday 04 July 2005 13:11, Steven Bosscher wrote:
> a few more things that look just wrong:
> > +       gcc_assert (GFC_DESCRIPTOR_TYPE_P (type));
> > +       size = gfc_conv_array_stride (array, rank);
> > +       tmp = fold_build2 (MINUS_EXPR, gfc_array_index_type,
> > +               gfc_conv_array_ubound (array, rank),
> > +               gfc_conv_array_lbound (array, rank));
> > +       tmp = fold_build2 (PLUS_EXPR, gfc_array_index_type, tmp,
> > +               gfc_index_one_node);
> > +       size = fold_build2 (MULT_EXPR, gfc_array_index_type, tmp, size);
>
> This can't be right.  gfc_conv_array_stride returns a COMPONENT_REF,
>  so the last line here tries to multiply gfc_array_index_type and a
> COMPONENT_REF.  Very Wrong thing to do.

Brain fart.  This is not wrong at all.  Ignore me.

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]