This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] Fix problem with the rename of pp_format_text to pp_format in the java front-end


Zack Weinberg <zack@codesourcery.com> writes:

| Andrew Pinski <pinskia@physics.uc.edu> writes:
| 
| > This fixes the problem with compiling the java front-end.
| 
| This is, sadly, not a complete fix.  pp_format() does not produce

agreed.

| output; you need to call pp_output_formatted_text() too.  (The name is
| confusing, yes; feel free to rename it to something more sensible, if
| you can think of one.)  See pretty_print.c:pp_printf() for the proper
| way to do it.

Part of what made reviewing your change difficult was the
implementation of intended semantics combined with renaming.  In
retrospect, those renamings should have been kept to the minimum, not
just you did not like them.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]