This is the mail archive of the
mailing list for the GCC project.
Re: Re-revised patch for numbered format specifiers in diagnostics
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 30 Jun 2005 16:11:22 -0700
- Subject: Re: Re-revised patch for numbered format specifiers in diagnostics
- References: <42B9809B.email@example.com>
Zack Weinberg <firstname.lastname@example.org> writes:
> [Sorry, I seem to have lost your message.]
> I took your revised patch, the one that used strings as an intermediate form,
> and revised it again. It now does not need to copy a scratch pretty_printer
> structure over the real one, nor does it need to parse the format string three
> times. I am still not totally happy with it, but I don't think we can do
> better without rewriting pretty-print.c and all its "subclass"ers, which I am
> not motivated to do. What do you think?
> This gets no regressions on i686-linux (c, c++, objc, objc++). Also, I
> hand-tested a couple of diagnostics that use %n$ in the Turkish translation;
> they work.
Jakub not having commented, I am checking this in unilaterally. It
may not be perfect, but it does fix this long-standing bug to my