This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: PR testsuite/21865 (really a middle-end vector bug)


>	PR testsuite/21865
>	* stor-layout.c (layout_type): Do not align beyond BIGGEST_ALIGNMENT.

I tried this on 4.0.1 and found one regression:

Executing on host: /mnt/gnu/gcc-3.3/objdir/gcc/xgcc -B/mnt/gnu/gcc-3.3/objdir/gc
c/ /mnt/gnu/gcc-3.3/gcc/gcc/testsuite/gcc.dg/align-2.c    -S  -o align-2.s    (t
imeout = 300)
/mnt/gnu/gcc-3.3/gcc/gcc/testsuite/gcc.dg/align-2.c:6: error: size of array 'com
pile_time_assert' is negative
compiler exited with status 1
output is:
/mnt/gnu/gcc-3.3/gcc/gcc/testsuite/gcc.dg/align-2.c:6: error: size of array 'com
pile_time_assert' is negative

Looking at the test, I would say it should be xfailed.

Your patch seems reasonable to me but I can't approve it.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]