This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] New function: current_function_has_landing_pads


On Jun 26, 2005, at 3:08 PM, Roger Sayle wrote:
In fact, except.c seems to be particularly poor with respect to per function documentation,

We welcome your contribution!


which presumably must be a source of some embarrassment to the unfortunate contributor named at the top of the source file :)

Not at all.


The large comment at the top of the file describes what an exception is, but fails to clarify how they are implemented, for example describing what a landing pad is.

`Landing pads' are a feature post the main contributor of the file named at the top of the file. In the the early years, they were just exception handlers, and, if you fetch version 1.1, you'll notice someone ripped out most of the fine documentation the original contributor added about things like exception handlers. Further, as you can see in 1.1 rev, the file was better commented than the current version, which is no fault of the original contributor.


So, if you want to throw mud, be sure to throw it at the right person. cvs diff/log will tell you all the right people, if you're interested.

;-)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]