This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, committed] PPC405 atomic support (PR target/21760)


On Thu, Jun 23, 2005 at 10:35:30PM -0400, Andrew Pinski wrote:
> 
> On Jun 23, 2005, at 10:03 PM, Geoffrey Keating wrote:
> 
> >David Edelsohn <dje@watson.ibm.com> writes:
> >
> >I think you might be able to get away with
> >
> >#define ppc405_is_default (strcmp(TARGET_CPU_DEFAULT, "405") == 0)
> 
> I suggest a different way to David via IRC when he was writing this code
> to fix this. Change config.gcc to add a define when --with-cpu=405 is
> supplied which in turn turns on the check but David rejected it saying 
> that
> is it was going to be too hard to maintain.

Why does this need to be a preprocessor check - why not do this based
on -mcpu=405 instead of --with-cpu=405?

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]