This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING Re: gfortran PATCH was Re: [simplify.c] bug?


On Sat, Jun 18, 2005 at 09:37:47AM -0700, Steve Kargl wrote:
> On Sat, Jun 18, 2005 at 12:17:06PM +0200, Steven Bosscher wrote:
> > 
> >   gfc_suppress_error = 0;
> >   if (do_simplify (specific, expr) == FAILURE)
> >     return MATCH_ERROR;
> > 
> >   /* TODO: We should probably only allow elemental functions here.  */
> >   flag |= (expr->ts.type != BT_INTEGER && expr->ts.type != BT_CHARACTER);
> > 
> >   gfc_suppress_error = 0;
> >   if (pedantic && gfc_init_expr
> > 
> > 
> > I would hope do_simplify cannot change gfc_suppress_error, the second
> > "gfc_suppress_error = 0;" should now be redundant.  Can you check that
> > please?
> 
> You are correct.  I noticed the extra gfc_suppress_error = 0 after
> I cut the original diff.  I was going to delete the extra one
> under the "obviously correct" rule.


Committed to 4.1.  I'll commit it to 4.0 when it re-opens.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]