This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] MIPS: mips16e machine patterns - zeb/zeh seb/seh

David Ung <davidu@mips.com> writes:
> So here we have it then, the new patch.

Looks good to me.  I think the doc part could be worded better though.

> *** 9836,9842 ****
>   @itemx -mno-mips16
>   @opindex mips16
>   @opindex mno-mips16
> ! Use (do not use) the MIPS16 ISA@.
>   
>   @item -mabi=32
>   @itemx -mabi=o64
> --- 9836,9844 ----
>   @itemx -mno-mips16
>   @opindex mips16
>   @opindex mno-mips16
> ! Use (do not use) the MIPS16 ASE@.
> ! 
> ! Note that if ISA is mips32/mips32r2/mips64, the MIPS16e ASE is used.

How about:

    Generate (do not generate) MIPS16 code.  If GCC is targetting a
    MIP32 or MIPS64 architecture, it will make use of the MIPS16e ASE@.

Not a huge improvement, but I hope it is at least grammatical ;)

As far as I'm concerned, the patch is OK with that change.  Give Eric
a chance to object though.

Richard
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]