This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: Improve ability to convert loops to perfect nests
On Sat, 2005-06-11 at 14:52 +0200, Sebastian Pop wrote:
> > +replace_uses_equiv_to_x_with_y (struct loop *loop, tree stmt, tree x, int xstep,
> > + tree y)
> > {
> > ssa_op_iter iter;
> > use_operand_p use_p;
> >
> > FOR_EACH_SSA_USE_OPERAND (use_p, stmt, iter, SSA_OP_USE)
> > {
> > - if (USE_FROM_PTR (use_p) == x)
> > + tree use = USE_FROM_PTR (use_p);
> > + tree step = NULL_TREE;
> > + tree access_fn = NULL_TREE;
> > +
> > +
> > + access_fn = instantiate_parameters
> > + (loop, analyze_scalar_evolution (loop, use));
> > + if (access_fn != NULL_TREE)
> > + step = evolution_part_in_loop_num (access_fn, loop->num);
> > + if ((step && int_cst_value (step) == xstep)
>
> I don't think that it is safe to have a call to int_cst_value without
> previously checking that step really is an INTEGER_CST.
This is true.
Sigh.
I'll fix.