This is the mail archive of the
mailing list for the GCC project.
Re: [Patch] MIPS: mips16e machine patterns - zeb/zeh seb/seh
- From: Richard Sandiford <rsandifo at nildram dot co dot uk>
- To: David Ung <davidu at mips dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 10 Jun 2005 14:09:24 +0100
- Subject: Re: [Patch] MIPS: mips16e machine patterns - zeb/zeh seb/seh
- References: <firstname.lastname@example.org>
David Ung <email@example.com> writes:
> Looks like we've agreed to leave in the -mips16e option then.
> here is a revised patch. I've added a few lines in the manual and now
> use GENERATE_MIPS16E instead, since TARGET_MIPS16E is already generated
> by mips.opt.
I'm a bit confused here. I thought the two options under discussion were:
(a) -mips16e as a separate flag. You get MIPS16e instructions
if and only if you use -mips16e.
(b) -mips16 is always used to enable MIPS16(e) instructions.
The -march setting decides whether MIPS16e is available.
(a) was what your first patch did and (b) was what I mentioned in
the review (purely for discussion purposes ;).
Like you say, the balance of opinion was that having a separate
flag was better than (b), but you now seem to have gone for a
hybrid in which -mips16 sometimes selects MIPS16 and sometimes
selects MIPS16e. Why did you do that rather than stick with