This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH to read-rtl.c

Andrew Pinski <> writes:

| On Jun 9, 2005, at 1:26 PM, Gabriel Dos Reis wrote:
| > Hi,
| >
| >   This patchlet converts gcc/read-rtl.c to the common subset of C
| > and C++.
| > The issues here mostly have to do with the implicit conversion
| > integer -> enumerations.  I post it seperately only to explain the
| > "extreme" case of mechanical conversion involved.
| I don't like this.  I don't understand you are converting the .c
| files,

I guess, it takes actual experiment of trying to compile the source
files to realize that one need to convert the actual .c files too.

I understand your definition of stupidity, but it would be even better
if you could show how in *practice*, you get source compile with
something that is not "stupidity", according to you.

| really
| the only thing which should be changed instead are the .h files to
| support C++ source files,

May I remind you that, the current state of the .c sources violates
our own coding convention and therefore needs conversion?

-- Gaby

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]