This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Some builtin functions for the Blackfin


Richard Henderson wrote:
On Wed, Jun 08, 2005 at 11:24:19AM +0200, Bernd Schmidt wrote:

* config/bfin/bfin.h (enum bfin_builtins): New.


There's no real reason to have this enumeration in your .h file.
It'll only cause full rebuilds when adding new builtins.

Good point. I just cut&pasted from the 3.4 version of config/i386 without thinking too much. I've committed the following to fix it.



Bernd


	* config/bfin/bfin.c (enum bfin_builtins): Moved here from...
	* config/bfin/bfin.h (enum bfin_builtins): ... here.

Index: config/bfin/bfin.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/bfin/bfin.c,v
retrieving revision 1.12
diff -c -p -r1.12 bfin.c
*** config/bfin/bfin.c	8 Jun 2005 09:25:11 -0000	1.12
--- config/bfin/bfin.c	9 Jun 2005 11:18:06 -0000
*************** bfin_output_mi_thunk (FILE *file ATTRIBU
*** 2671,2676 ****
--- 2671,2684 ----
      output_asm_insn ("jump.l\t%P0", xops);
  }
  
+ /* Codes for all the Blackfin builtins.  */
+ enum bfin_builtins
+ {
+   BFIN_BUILTIN_CSYNC,
+   BFIN_BUILTIN_SSYNC,
+   BFIN_BUILTIN_MAX
+ };
+ 
  #define def_builtin(NAME, TYPE, CODE)				\
  do {								\
    builtin_function ((NAME), (TYPE), (CODE), BUILT_IN_MD,	\
Index: config/bfin/bfin.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/bfin/bfin.h,v
retrieving revision 1.6
diff -c -p -r1.6 bfin.h
*** config/bfin/bfin.h	8 Jun 2005 09:40:42 -0000	1.6
--- config/bfin/bfin.h	9 Jun 2005 11:18:06 -0000
*************** do {                                    
*** 989,1002 ****
  #define EXTRA_CONSTRAINT(VALUE, D) \
      ((D) == 'Q' ? GET_CODE (VALUE) == SYMBOL_REF : 0)
  
- /* Codes for all the Blackfin builtins.  */
- enum bfin_builtins
- {
-   BFIN_BUILTIN_CSYNC,
-   BFIN_BUILTIN_SSYNC,
-   BFIN_BUILTIN_MAX
- };
- 
  /* `FINALIZE_PIC'
       By generating position-independent code, when two different
       programs (A and B) share a common library (libC.a), the text of
--- 989,994 ----

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]