This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [wwwdocs] mainline is stage two


R Hill wrote:
Gerald Pfeifer wrote:
For some reason your patch did not apply for me, so I made the change manually and commit them. Thanks!


> Hmm, that's the second time that's happened. Do you see anything
> obviously wrong with the diff? I think I might start doing manual
> diffs instead of using cvs from now on.

Nothing is actually wrong with diff or cvs diff; what is "wrong" is that you are using Mozilla Thunderbird and cut-and-pasting your patches into the text.

Thunderbird, by default uses Format Flowed (RFC 2646), which is generally a nice feature but since it will reformat linebreaks makes included patches unuseable.

Two potential fixes.

a) Turn off sending in format flowed.

Add the following line to your users.js:
user_pref("mailnews.send_plaintext_flowed", false);

b) Attach your patches instead of cut-and-pasting them into the text. As long as there are no eight bit characters, Thunderbird is smart enough to attach them as inline text instead BASE64. This is the better solution, IMO.

Kelley Cook


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]