This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR 20666, take 2

>   This is my second attempt to fix pr 20666.  The only changes from the
> last time I submitted this patch is that the pdist folding has been
> changed. The testcases have not changed and are still at
> .

Very, very minor nits:

+   Fold builtin functions for sparc instrinsics.  If INGNORE is true the
+   result of the function call is ignored.  NULL_TREE is returned if the
+   function could not be folded.  */


+  tree rtype = TREE_TYPE (TREE_TYPE (fndecl));
+  if (ignore

Superfluous new line.

+	      short val = TREE_INT_CST_LOW (TREE_VALUE (elts)) << 4;

'int' at least, please.

+	      unsigned HOST_WIDE_INT low0 = TREE_INT_CST_LOW (TREE_VALUE (elts0));
+	      HOST_WIDE_INT high0 = TREE_INT_CST_HIGH (TREE_VALUE (elts0));
+	      unsigned HOST_WIDE_INT l, low1 = TREE_INT_CST_LOW (TREE_VALUE 
+	      HOST_WIDE_INT high1 = TREE_INT_CST_HIGH (TREE_VALUE (elts1));
+	      HOST_WIDE_INT h;

This should be fully symmetric.

OK with these changes.

>  Christian Joensson bootstrapped and regtested this new patch on
> sparc-linux, C only, with no new regressions.  Sorry I can't test anymore,
> but I don't have any machines to test on.

Thanks to both of you (and again sorry for the inexcusable initial delay).

Eric Botcazou

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]