This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Fix 21280

From: Nathan Sidwell <nathan at codesourcery dot com>
To: DJ Delorie <dj at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 06 Jun 2005 11:09:50 +0100
Subject: Re: [C++ PATCH] Fix 21280
References: <429F43B3.3060202@codesourcery.com> <429F48CC.90101@codesourcery.com> <xnk6lco8u0.fsf@greed.delorie.com> <429F6601.5010400@codesourcery.com> <200506022007.j52K7qQl029812@greed.delorie.com>

DJ Delorie wrote:

!     warning (0, "%Hsynthesized method %qD first required here ",
 	     &input_location, fndecl);

Could you put something other than 0 there?  I'm working on converting
all those zeros to OPT_* constants...

Um, what do you suggest? We're issuing this warning because we've just emitted an error or warning that occurred during synthesizing something. For the error case, I think we should unconditionally provide this additional location information. For the warning case (which I'm not sure can actually occur), the user obviously requested the initial warning, why should we not provide additional location information?

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Follow-Ups:
- Re: [C++ PATCH] Fix 21280
  - From: Giovanni Bajo
- Re: [C++ PATCH] Fix 21280
  - From: DJ Delorie

References:
- [C++ PATCH] Fix 21280
  - From: Nathan Sidwell
- Re: [C++ PATCH] Fix 21280
  - From: Nathan Sidwell
- Re: [C++ PATCH] Fix 21280
  - From: Nathan Sidwell
- Re: [C++ PATCH] Fix 21280
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]