This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Use gcc-internal-format instead of c-format or nothing in gcc.pot where needed (take 2)


On Wed, Jun 01, 2005 at 12:25:18PM +0000, Joseph S. Myers wrote:
> On Wed, 1 Jun 2005, Jakub Jelinek wrote:
> 
> > The patch assumes gettext 0.14.5 or later, not sure how we should
> > enforce it (and not sure for which operations is that version really
> > necessary, only for make gcc.pot and msgmerge or also for msgfmt?).
> > Also, the patch is against HEAD, but as 4.0 and HEAD uses the same
> > .po files, not sure if we need a 4.0 version of the patch as well.
> 
> The only .pot files going to the TP for some time will be from 4.0 branch, 
> so 4.0 needs patching as well; 4.1 .pot files won't start going to the TP 
> until either 4.1 has branched or at least it is near branching.

Ok, attached are both 4.0 and (updated) 4.1 patches.

> doc/install.texi needs updating with the new minimum gettext version.  If 

Done.

> there are problems running msgfmt with old msgfmt but new .po and .pot 
> files then configure changes will be needed to allow for that (to avoid 
> breaking builds from CVS for those with old msgfmt); otherwise configure 
> changes may not be needed.

As GCC does not run msgfmt with --check-format or similar options,
older msgfmt seems to work just fine (tested with 0.14.3 as well as
0.14.5).  So I think we can just require 0.14.5 for i18n maintainers
(for make gcc.pot and make update-po) and translators, other
developers/users should be able to make build-po just fine even with older
gettexts.

> The new conventions should also be noted in ABOUT-GCC-NLS.

Done.

Ok for HEAD and 4.0 (I guess after 4.0.1 is released)?

	Jakub

Attachment: gcc41-l10n-diagnostic.patch
Description: Text document

Attachment: gcc4-l10n-diagnostic.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]