This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping: remove duplication in mklibgcc.in


Ben Elliston <bje@au1.ibm.com> writes:

> I posted this patch some weeks ago and received one response (from
> Andreas Shwab, I believe).  I incorporated his suggestion, but never
> received an approval.  Posting again.  Okay for mainline?
...

> +    bit=$(eval "echo \$$bitvar")
> +    bit_funcs=$(eval "echo \$$bit_funcs_var")

Don't use $(...) when it means `...` in this file.  It may well be
portable enough for our purposes, but it is still in danger of being
confused with $(...) meaning a variable to be expanded by Make, not by
the shell script.

Otherwise OK.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]