This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for PR fortran/21375


On Sun, Jun 05, 2005 at 06:46:12PM +0100, Paul Brook wrote:
> > See attached patch (for a fun exercise in hacking).
> > Bootstrapped and regression tested on i386-*-freebsd.
> > ChangeLog entries for patch and test case are the
> > same as in the first email of the thread.
> 
> >+       apstat = gfc_build_addr_expr (NULL, astat);
> >+       apstat = build_int_cst (gfc_int4_type_node, 0);
> 
> This looks wrong. Assigning to a variable then immediately overwriting its 
> value.
> 
> Presumably there should be some library changes to go with this patch?
> It's also missing a ChangeLog entry.
> 
> It would also be nice to have a comment that explained (in C or pseudocode) 
> what we the code we generate should look like.
> 

See patch.

2005-06-04  Steven G. Kargl  <kargls@comcast.net>

	PR fortran/17792
	PR fortran/21375
	* trans-array.c (gfc_array_deallocate): pstat is new argument
	(gfc_array_allocate): update gfc_array_deallocate() call.
	(gfc_trans_deferred_array): ditto.
	* trans-array.h: update gfc_array_deallocate() prototype.
	* trans-decl.c (gfc_build_builtin_function_decls): update declaration
	* trans-stmt.c (gfc_trans_deallocate): Implement STAT= feature.

2005-06-04  Steven G. Kargl  <kargls@comcast.net>
  
	PR fortran/17792
	PR fortran/21375
	* gfortran.dg/pr21375.f90:  New test.


-- 
Steve

Attachment: pr21375.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]