This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for PR fortran/21375


> See attached patch (for a fun exercise in hacking).
> Bootstrapped and regression tested on i386-*-freebsd.
> ChangeLog entries for patch and test case are the
> same as in the first email of the thread.

>+       apstat = gfc_build_addr_expr (NULL, astat);
>+       apstat = build_int_cst (gfc_int4_type_node, 0);

This looks wrong. Assigning to a variable then immediately overwriting its 
value.

Presumably there should be some library changes to go with this patch?
It's also missing a ChangeLog entry.

It would also be nice to have a comment that explained (in C or pseudocode) 
what we the code we generate should look like.

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]