Re: C++ PATCH: PR 21336

[Mark Mitchell <mark at codesourcery dot com>]

Andrew Pinski wrote:
> > > + 	  if (what)
> > > + 	    warning (0, "conversion to %s%s will never use a type "
> > > + 		     "conversion operator",
> > > + 		     ref ? "a reference to " : "", what);
> >
> > I know this is just moved from elsewhere, but can we replace those
> > zeros as we encounter them?

We can, but I did not.  I don't think that should be a requirement on 
patches, especially patches that are being backported to other branches, 
where this will just increase merge conflicts.

> Also does this violate the internalization code style?

Yes, but, I think that's a lower-priority problem that fixing the core 
PR.  I did not have time to do these associated clean-ups while fixing 
the core PR.  Incremental progress!

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304