This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] testsuite: fix ppc-vector-memcpy

From: Josh Conner <jconner at apple dot com>
To: Richard Henderson <rth at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 3 Jun 2005 09:08:32 -0700
Subject: Re: [patch] testsuite: fix ppc-vector-memcpy
References: <9C113326-4800-4410-8FB6-48EFA8BAE080@apple.com> <20050603015437.GB12806@redhat.com>

On Jun 2, 2005, at 6:54 PM, Richard Henderson wrote:

On Thu, Jun 02, 2005 at 04:03:24PM -0700, Josh Conner wrote:

    gcc.dg/ppc-vector-memcpy.c: Sparse local arrays no longer trigger
    a memcpy.  Added initializers for all elements.


Ok, except that this is not a correctly formatted changelog entry.
Nor does one document "why" in the changelog, only "what".  "Why"
goes into the source code as comments.

    * gcc.dg/ppc-vector-memcpy.c (foo): Use non-zero values for
    all entries in initializer.

r~

Got it - thanks. Committed with suggested changelog.

- Josh

References:
- [patch] testsuite: fix ppc-vector-memcpy
  - From: Josh Conner
- Re: [patch] testsuite: fix ppc-vector-memcpy
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]