This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] GCSE considers read only memory clobbered by functioncalls -- Fix
- From: Roger Sayle <roger at eyesopen dot com>
- To: Mostafa Hagog <MUSTAFA at il dot ibm dot com>
- Cc: law at redhat dot com, <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 31 May 2005 08:46:43 -0600 (MDT)
- Subject: Re: [PATCH] GCSE considers read only memory clobbered by functioncalls -- Fix
On Tue, 31 May 2005, Mostafa Hagog wrote:
> 2005-05-31 Mostafa Hagog <mustafa@il.ibm.com>
>
> * gcse.c (compute_transp, load_killed_in_block): use MEM_READONLY_P.
>
Given that Jeff has already pre-approved a previous version of this
patch, this is OK for mainline with two minor changes.
> + /* If this is a readonly then we aren't going to be chaning it. */
> + if (MEM_READONLY_P (x))
> + return 0;
Comment typo "changing".
> ! if (! MEM_READONLY_P (x))
> ! {
>
> ! bitmap_iterator bi;
> ! unsigned bb_index;
No blank line between the opening brace and the variable declarations
at the start of a block.
Thanks,
Roger
--