This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree profiling branch] folding constant in cond expr ( for versionednode)


Steven Bosscher <stevenb@suse.de> wrote on 31/05/2005 09:41:26:

> On Monday 30 May 2005 13:44, Razya Ladelsky wrote:
> > Attached is a an addition of fold_cond_expr_cond () to
> > tree_function_versioning.
> > Also an obvious cleanup I missed in the previous cleanup patch.
> 
> The obvious cleanup is OK.
> 
> The tree-inline.c change is not OK, you should add a test case
> and at least a comment to explain why you must call that function
> there.
> 
The problem was when compiling a function in cp/mangle.c, where the formal 
was substituted 
with a constant (similar to what inlining does), in a conditional expr.
This produced a failure of not proper gimple code.
After consulting with Honza, it seems that this fix is the proper one for 
the moment, 
as it is what the inliner does in these cases.

I  encountered this problem when bootstrapping.
However, after the latest mainline merge, bootstrapping passes without 
this fix.
Maybe the fix is not necessary at the moment, but I still think it should 
be there.
What do you think?


> Gr.
> Steven
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]