Re: RFA: Add a check_pch_target_flags target hook

[Mike Stump <mrs at apple dot com>]

On May 26, 2005, at 11:13 PM, Richard Sandiford wrote:
> At the moment I'm trying to achieve the twin goals of:
>
>   (a) getting rid of TARGET_SWITCHES and TARGET_OPTIONS; and
>   (b) applying PCH validity checks to general .opt options.

I like the direction, I think it is good.

> However, the long-term plan is to have a loop like:
>
>    for (i = 0; i < cl_options_count; i++)
>      if (option_affects_pch_p (i))
>        ...check option validity...

Looks about right.

> ports, there would be no point in handling target_flags as a  
> special case.
> SH is (hopefully) unusual

I suspect sh isn't unusual.

> ! #ifdef TARGET_OPTIONS
> !   /* ??? We have a copy of this in toplev.c, but it is static.  */
> !   static const struct
> !     {
> !       const char *const prefix;
> !       const char **const variable;
> !       const char *const description;
> !       const char *const value;
> !     }
> !   target_options[] = TARGET_OPTIONS;

Don't like this part...  I think in the next or so step, this goes  
away...

> OK to install?

I like it, I'm looking forward to the next step or three...

Also, I suspect the manual needs to document which options on which  
targets affect PCHness at some point.