This is the mail archive of the
mailing list for the GCC project.
Re: [patch]Follow-on for aliasing on vector replacements to match original
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Keith Besaw <kbesaw at us dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Dorit Naishlos <DORIT at il dot ibm dot com>, rakdver at atrey dot karlin dot mff dot cuni dot cz
- Date: Fri, 27 May 2005 14:14:06 -0400
- Subject: Re: [patch]Follow-on for aliasing on vector replacements to match original
- References: <OFCE1D1F4E.5DACAA56-ON8625700D.0029670E-8625700D.0041F9B6@us.ibm.com>
On Thu, May 26, 2005 at 07:00:36AM -0500, Keith Besaw wrote:
> + /* FIXME, if aliases has just one member mbr which satisfies
> + get_var_ann (mbr)->mem_tag_kind == TYPE_TAG then should
> + p_ann->type_mem_tag be set to mbr (and avoid the call to
> + create_memory_tag)? */
No. This would defeat your purpose. When you call this
function, you know that all SSA version numbers of 'ptr' will
only ever point to 'var'. If you make it share the tag for
'var', then you will effectively make it alias all the aliases
for 'var', which is not what you want.
> + size_t i;
> + for (i = 0; i < VARRAY_ACTIVE_SIZE (aliases); i++)
> + add_may_alias (tag, VARRAY_TREE (aliases, i));
> + }
> + }
> + /* Note, TAG and its set of aliases are not marked for renaming. */
Move this comment to the start of the function, please.
Mind line wrapping. Lines should be less than 80 columns. The
rest looks fine. Will you submit the ivopts bits separately?