This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Objective-C++ testsuite


On Thu, May 26, 2005 at 02:13:25PM -0700, Ziemowit Laski wrote:
> 
> On 26 May 2005, at 14.01, Janis Johnson wrote:
> 
> >On Wed, May 25, 2005 at 07:04:39PM -0700, Mike Stump wrote:
> >>Here is the main bulk of the Objective-C++ testsuite.
> >>
> >>Tested on powerpc-apple-darwin8.  Let us know of any non-
> >>portabilities in it...  I'm sure there are some...  make check-obj-c+
> >>+ after enabling obj-c++ will run them.
> >
> >I don't know why you didn't run into the same problem, but I needed to
> >add "global srcdir" to obj-c++_target_compile in obj-c++.exp in order
> >to get anywhere.  With that change I ran the tests on powerpc64-linux
> >with -m32 and -m64.  There were several test failures, especially with
> >-m64, but no more infrastructure problems.
> 
> Janis, could you commit your fix for obj-c++_target_compile() to 
> mainline?
> Many thanks.

The following has been tested on powerpc64-linux with -m32/-m64 and
checked in on mainline.

2005-05-26  Janis Johnson  <janis187@us.ibm.com>

	* lib/obj-c++.exp (obj-c++_target_compile): Declare global variable,
	remove extraneous semicolons.

Index: lib/obj-c++.exp
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/lib/obj-c++.exp,v
retrieving revision 1.2
diff -u -p -r1.2 obj-c++.exp
--- lib/obj-c++.exp	20 May 2005 22:14:16 -0000	1.2
+++ lib/obj-c++.exp	26 May 2005 21:22:31 -0000
@@ -284,11 +284,12 @@ proc obj-c++_init { args } {
 #
 
 proc obj-c++_target_compile { source dest type options } {
-    global tmpdir;
+    global tmpdir
+    global srcdir
     global gpp_compile_options
     global gluefile wrap_flags
-    global ALWAYS_OBJCXXFLAGS;
-    global OBJCXX_UNDER_TEST;
+    global ALWAYS_OBJCXXFLAGS
+    global OBJCXX_UNDER_TEST
 
     lappend options "libs=-lobjc"
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]