This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Trivial fix for objc.dg/selector-2.m test case

On 25 May 2005, at 16.31, Andrew Pinski wrote:

On May 25, 2005, at 7:23 PM, Ziemowit Laski wrote:
That is not the right thing to do, this is testing to make sure we
don't ICE when compiling -fgnu-runtime.

If the compiler ICEs, the test will still fail; I don't follow you.

Yes but we are now not testing -fgnu-runtime on ppc-darwin but -fnext-runtime, this is a dup of testcase selector-1.m then and really does not test anything on powerpc-darwin unless someone supplies -fgnu-rumtime.

Ok, I see what you're saying. Thing is, selector-2.m is not well suited
to testing -fgnu-runtime on Darwin, due to the #include <objc/Object.h>.
What we need is a mirror image of selector-1.m, with -fgnu-runtime instead
of -fnext-runtime. The new selector-2.m is still useful, since it exercises
the default runtime used by a particular target.

I'll whip up a selector-3.m.

Ziemowit Laski                 1 Infinite Loop, MS 301-2K
Mac OS X Compiler Group        Cupertino, CA USA  95014-2083
Apple Computer, Inc.           +1.408.974.6229  Fax .5477

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]