This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [java] Fix builtins decls


> On Mon, May 23, 2005 at 07:24:00PM +0100, Andrew Haley wrote:
> > Jan Hubicka writes:
> >  > Hi,
> >  > tree-profiling branch dies horribly by trying to remove
> >  > __builtin_predict calls since these are believed to be trapping in Java.
> >  > I've bootstrapped/regtested i686--linux the attached patch on
> >  > tree-profiling and I am testing it on mainline now too.
> >  > OK (once mainline unslush, as this does not counts as a regression
> >  > there)
> >  > 
> >  > 2005-05-22  Jan Hubicka  <jh@suse.cz>
> >  > 	* builtins.c (define_builtin): Accept new flags parameter.
> >  > 	(initialize_builtins): Mark the builtins const and nothrow accordingly.
> > 
> > That's fine except for __builtin_expect, which is neither const nor
> > nothrow.
> 
> Why wouldn't it be?  It doesn't do anything.  What the arguments do is
> not the builtin's problem.
Ehm...My problem is that builtin_expect itself is marked as throwing and
non-constant.  Tree-profiling branch preplace the builtin_expect calls
by it's argument getting dead EH edges.
Rather then removing the EH edges it seems better to mark the function
as non-trapping and constant...

Honza
> 
> -- 
> Daniel Jacobowitz
> CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]