This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix reg-stack ICE (PR target/21716)
- From: Roger Sayle <roger at eyesopen dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 23 May 2005 08:22:43 -0600 (MDT)
- Subject: Re: [PATCH] Fix reg-stack ICE (PR target/21716)
On Mon, 23 May 2005, Jakub Jelinek wrote:
> 2005-05-23 Jakub Jelinek <email@example.com>
> PR target/21716
> * reg-stack.c (swap_rtx_condition): Don't crash if %ax user was not
> found in the basic block and last insn in the basic block is not
> INSN_P. Remove explicit unspec numbers that are no longer valid
> from comments.
After fixing the unterminated comment in the bugzilla testcase,
I've confirmed that this is a 3.4 regression from at least 3.2
(neither your post nor the bugzilla PR mentioned whether this
was a regression or not). As a regression fix, this is OK for
mainline, gcc-4_0-branch and gcc-3_4-branch.
If its not too much trouble, the protocols for the current slush
period aren't clearly defined, and so for corner cases like this
(where the regression is present but latent on mainline), it might
be preferable to wait a few days before committing your patch
to CVS (even though the patch itself should be completely safe).
Thanks in advance,