This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: SPARC: minor tweaks

From: Eric Botcazou <ebotcazou at libertysurf dot fr>
To: David S. Miller <davem at davemloft dot net>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 17 May 2005 22:27:59 +0200
Subject: Re: SPARC: minor tweaks
References: <200505151228.23213.ebotcazou@libertysurf.fr> <200505172207.35468.ebotcazou@libertysurf.fr> <20050517.132032.93023364.davem@davemloft.net>

> >    /* Slick... but this trick loses if this subreg constant part
> >       can be done in one insn.  */
> > -  if (low == high && (low & 0x3ff) != 0 && low + 0x1000 >= 0x2000)
> > +  if (low == high
> > +      && ! SPARC_SETHI32_P (high)
> > +      && ! SPARC_SIMM13_P (high))
>
> SPARC_SIMM13_P() should be run against "low" not "high".

Stylistically?  The idiom is used in 2 other places like that.

-- 
Eric Botcazou

Follow-Ups:
- Re: SPARC: minor tweaks
  - From: David S . Miller

References:
- Re: SPARC: minor tweaks
  - From: Eric Botcazou
- Re: SPARC: minor tweaks
  - From: Eric Botcazou
- Re: SPARC: minor tweaks
  - From: David S . Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]