This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] ARM: Don't use weak linkage when comdat groups are available

From: Paul Brook <paul at codesourcery dot com>
To: Julian Brown <julian at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 17 May 2005 16:17:53 +0100
Subject: Re: [PATCH] ARM: Don't use weak linkage when comdat groups are available
References: <428894A7.1090402@codesourcery.com> <200505162205.46858.paul@codesourcery.com> <4289FF53.7050407@codesourcery.com>

On Tuesday 17 May 2005 15:27, Julian Brown wrote:
> Paul Brook wrote:
> > On Monday 16 May 2005 13:43, Julian Brown wrote:
> >>Julian Brown wrote:
> >>>ChangeLog:
> >>>
> >>>  * config/arm/arm.h (MAKE_DECL_ONE_ONLY): Redefine macro to stop
> >>>  DECL_WEAK being used for symbols with vague linkage when
> >>>  HAVE_COMDAT_GROUP is true.
> >
> > Are old arm-linux targets liable to have the same problems as you were
> > seeing on other targets?
> >
> > If so we probably only want to do this for EABI based targets. We know
> > these will be using recent binutils with working COMDAT.
>
> One of my previous patches disabled COMDAT support for all binutils
> versions less than 2.16, so I think it should be OK. I haven't tried
> arm-linux-elf with this patch at all though, so perhaps I'd better run
> tests to be sure.

Ok. That's good enough for me.

Paul

References:
- [PATCH] ARM: Don't use weak linkage when comdat groups are available
  - From: Julian Brown
- Re: [PATCH] ARM: Don't use weak linkage when comdat groups are available
  - From: Paul Brook
- Re: [PATCH] ARM: Don't use weak linkage when comdat groups are available
  - From: Julian Brown

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]