This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC,patch] ARM EABU unwinding/exception handling
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org, rth at redhat dot com
- Date: Tue, 17 May 2005 14:08:21 +0000 (UTC)
- Subject: Re: [RFC,patch] ARM EABU unwinding/exception handling
- References: <200505170319.21804.paul@codesourcery.com>
On Tue, 17 May 2005, Paul Brook wrote:
> The attached patch implements support for ARM EABI unwinding and c++ exception
> handling. The original patch (against csl-arm-branch) can be found here:
> http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02165.html
Please make sure that each new function definition has a comment above it
describing what the function does and the significance of the arguments
and return value if any. Some functions (e.g. in config/arm/pr-support.c)
have no comments, others say nothing about the parameters.
I think the documentation should refer to @code{true} and @code{false}
rather than @code{TRUE} and @code{FALSE}. tm.texi only refers to the
lowercase versions at present. The code has both, though I think we
should prefer the C99-and-C++-type lowercase versions for new code.
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
joseph@codesourcery.com (CodeSourcery mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)