This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ada PATCH] Clean-up Ada front-end use of TREE_OVERFLOW
- From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- To: roger at eyesopen dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 15 May 05 19:13:21 EDT
- Subject: Re: [Ada PATCH] Clean-up Ada front-end use of TREE_OVERFLOW
Diagnosing these these types of problem in GCC's Ada front-end would be
easier if the following patch could be approved (ping?):
http://gcc.gnu.org/ml/gcc-patches/2005-05/msg00175.html
That needs somebody who knows the pp stuff; it's OK with me if it looks
correct to them.
The following patch has been tested on i686-pc-linux-gnu, with a
bootstrap including Ada, and regression tested with a top-level "make
-k check" with no new failures. This patch resolves the 8 ACATS
regressions that would otherwise be introduced once TREE_OVERFLOW
checking is enabled.
Ok for mainline?
Probably, but I'd like to ask what the TREE_OVERFLOW checking will be
testing. If TREE_CODE_CLASS, then I think it's more consistent to do
the same check in max_size, but if a list of explicit codes, then I
agree with your patch.