This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Eliminate warnings about snprintf declaration

On Sat, May 14, 2005 at 01:05:51PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 12 May 2005 16:51:03 -0400
> > From: Daniel Jacobowitz <>
> > Cc:,
> > 
> > > So I need to add these functions to gdb/ _and_ to
> > > libiberty/; got it.  I will post a revised patch soon.
> > > 
> > > Thanks for your patience.
> > 
> > Almost - you don't actually need them in libiberty/, unless
> > you see warnings about them during the build of libiberty.  To make GDB
> > -Werror happy, all you need is gdb/ and
> > include/libiberty.h.
> Actually, I found that a simpler patch to include/libiberty.h (below)
> is all that is needed to fix all the warnings about snprintf and
> vsnprintf.  libiberty.h already does that for asprintf and vasprintf,
> so I think we can use the same method for snprintf and vsnprintf; no
> need to change any files.
> Okay?
> 2005-05-14  Eli Zaretskii  <>
> 	* libiberty.h: (snprintf) [!HAVE_DECL_SNPRINTF]: Declare if
> 	needed.
> 	(vsnprintf) [!HAVE_DECL_VSNPRINTF]: Declare if needed.

Note that this will only work if there are no systems which declare
snprintf with an incorrect prototype.  For instance, a missing const on
the format string in a system header would now generate an error.  For
asprintf this isn't an issue, because it's not a standard function;
it's only provided by glibc.

I don't know whether that's a real problem though.  I'll let DJ answer
that :-)

Daniel Jacobowitz
CodeSourcery, LLC

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]