Re: [PATCH] Vector return on ARM

[Josh Conner <jconner at apple dot com>]

On May 13, 2005, at 10:01 AM, Paul Brook wrote:

> > 2005-05-13 Josh Conner <jconner@apple.com>
> >
> >          * config/arm/arm.c (use_return_insn): Include test of which
> >          registers are being used to hold return values, to  
> > accommodate
> >          vector return values.
>
> There is a similar check in thumb_exit and  
> thumb_unexpanded_epilogue which
> uses a slightly different condition. I've not idea if/why this code is
> needed, but it's probably worth putting it out into a function (eg.
> arm_num_return_regs).
>
> Paul

OK - I pulled it out into a separate function (after making sure that  
the REG_P check I was doing was unnecessary).  I named the function  
"arm_size_return_regs", since that seemed to me to better reflect  
that the function returns a byte count, not word count.  Also, it  
didn't seem logical to use it in thumb_exit, since that function also  
uses the intermediate mode calculation -- let me know if I should  
reconsider this.

It's running tests right now, OK for mainline if no regressions?

Thanks -

Josh
~~~~

2005-05-13 Josh Conner <jconner@apple.com>

        * config/arm/arm.c (arm_size_return_regs): New.
        (thumb_unexpanded_epilogue): replace in-line calculation
        of return registers with call to arm_size_return_regs.
        (use_return_insn): Include test of which registers are
        being used to hold return values, to accommodate
        vector return values.

Attachment: epilogue2.patch
Description: Binary data