This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Stay in GIMPLE when inlining
- From: Jan Hubicka <jh at suse dot cz>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org, rth at redhat dot com
- Date: Fri, 13 May 2005 02:50:59 +0200
- Subject: Re: Stay in GIMPLE when inlining
- References: <20050512235633.GB18936@kam.mff.cuni.cz> <87fyws2bmt.fsf@codesourcery.com>
> Jan Hubicka <jh@suse.cz> writes:
>
> > Hi, this patch makes inliner to stay gimple so we don't need to
> > re-gimplify after inlining. Bootstrapped/regtested
> > i686-pc-gnu-linux, saves few seconds of compile time and some memory
> > too.
>
> Nice, but ...
>
> > + #ifdef ENABLE_CHECING
> > + verify_stmts ();
> > + #endif
>
> ... you typoed CHECKING, so you haven't tested with the verify_stmts
> call active. Please fix that and repeat your tests.
Will do, thanks for pointing this out!
It is embarassing that we don't do verify_stmts by default at all, it
seems to catch some bugs later in the queue BTW.
Honza
>
> zw