This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Stay in GIMPLE when inlining


> Jan Hubicka <jh@suse.cz> writes:
> 
> > Hi, this patch makes inliner to stay gimple so we don't need to
> > re-gimplify after inlining.  Bootstrapped/regtested
> > i686-pc-gnu-linux, saves few seconds of compile time and some memory
> > too.
> 
> Nice, but ...
> 
> > + #ifdef ENABLE_CHECING
> > +   verify_stmts ();
> > + #endif
> 
> ... you typoed CHECKING, so you haven't tested with the verify_stmts
> call active.  Please fix that and repeat your tests.

Will do, thanks for pointing this out!
It is embarassing that we don't do verify_stmts by default at all, it
seems to catch some bugs later in the queue BTW.

Honza
> 
> zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]