This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Eliminate warnings about snprintf declaration


"Eli Zaretskii" <eliz@gnu.org> writes:

> > I believe you've got this logic reversed.  You also don't want or need
> > the non-prototype - it's only needed for basename because basename
> > returns a pointer.  How about this, based on the later examples in the
> > file:
> 
> Okay.  But I guess I should wait for approval by libiberty maintainers
> first.

I think Dan's comments are correct in that the patch needs to be
fixed.  I, for one, would rather approve the final version of the
patch.

The general idea is fine.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]