This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
The bypasses look overly specific to me (presuming the precise form of a future header will mention __GNUC__ on the line before a particular definition). As they are all for the benefit of a hypothetical future header, I'd rather they just all bypassed on __GNUC__ and then if a future Solaris version does get released with some but not all cases fixed then the testcases you add should detect this and the bypasses can be refined then.
The reasoning is that we keep fixing unless we are sure we don't need to. Using only __GNUC__ seems hazardous, as it could pop up in another unrelated part of the header.
-- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |