This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: fix libiberty/pex-djgpp.c
- From: Ian Lance Taylor <ian at airs dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org, gdb-patches at sourceware dot org, djgpp-workers at delorie dot com
- Date: 11 May 2005 16:28:30 -0400
- Subject: Re: RFA: fix libiberty/pex-djgpp.c
- References: <01c5565c$Blat.v2.4$082130a0@zahav.net.il>
"Eli Zaretskii" <eliz@gnu.org> writes:
> The current CVS version of pex-djgpp.c didn't compile. The patch
> below fixes the problems I spotted; please review it.
Thanks for doing this. I did not have a DJGPP system to try this code
out on. It was obviously in fairly bad shape.
You don't need pex_djgpp_fdopenr. It will only be called if
pex_init_common is called with PEX_USE_PIPES, which should never
happen since pex_init in pex-djgpp.c clears PEX_USE_PIPES.
Otherwise, this patch is approved. Please check it into the gcc
repository first, as usual with libiberty patches.
Thanks.
Ian