This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed patch^3
- From: Richard Henderson <rth at redhat dot com>
- To: Andreas Krebbel <krebbel1 at de dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 10 May 2005 15:17:30 -0700
- Subject: Re: Unreviewed patch^3
- References: <20050509080525.GA3160@de.ibm.com>
On Mon, May 09, 2005 at 10:05:25AM +0200, Andreas Krebbel wrote:
> http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00659.html
The big if block at the front replicates much of the code that
follows it. Since offset is only accumulated, it doesn't seem
that you'd lose anything by moving that adjustment later and
not duplicating code.
More seriously,
! /* Do not combine registers if they overlap. */
! || (ureg - offset <= sreg && ureg + usize > sreg + MIN (offset, 0))
! || (ureg - offset >= sreg && ureg - MAX (offset, 0) < sreg + ssize)
Comparisons of ureg and sreg like this make no sense if they are
pseudo register numbers. What's wrong with the original offset check?
r~