This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix PR tree-optimization/21407

Daniel Berlin wrote:
It would seem rather dangerous to me to implement this optimization.

Again, it's been implemented and turned on for a couple months now, it's
not a proposal.  :)

Good point.

However, here is a patch to fully disable it and leave a note in it's
place for people who think of the same idea in the future.

I've added 21407 testcase to g++.dg/tree-ssa

Bootstrapped and regtested on i686-pc-linux-gnu
okay for mainline?

Kenny and I had a long conversation today, and we think we have a proposal that will satisfy both of us -- though we can't be sure about Geoff, et. al. The current state is that I transcribed the proposal, sent it to Kenny, and am waiting for him to confirm that it matches his understanding of what we think we agreed upon. If it does, we'll post it soon. Since it would leave these bits in, I think we should hold off on your patch for the moment.

The test case is OK, though until we check in your patch, it should be XFAILed for the moment. And you might want to add a note to the PR, so that we can avoid checking in another test case when we fix the PR, by whatever means.


Mark Mitchell
CodeSourcery, LLC
(916) 791-8304

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]