This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [s390] patch: add support for 'lzdr' and 'lzer'


Adrian Straetling wrote:

> 	* config/s390/s390.c: (s390_const_double_ok_for_constraint_p): New
> 	function.
> 	(legitimate_reload_constant_p): Add check for const double zero.
> 	* config/s390/s390.md: Add comment for constraint letter 'G'.
> 	("*movdf_64", "*movdf_31", "movsf"): Add constraint and proper
> 	attributes for new case.
> 	* config/s390/s390.h: (CONST_DOUBLE_OK_FOR_CONSTRAINT_P): Define it as
> 	s390_const_double_ok_for_constraint_p.
> 	* config/s390/s390-protos.h: Declare external
> 	s390_const_double_ok_for_constraint_p.

Looks fine, except that:

> !   [(set_attr "op_type" "RR,RX,RXY,RX,RXY,RRE,RXY,RXY,SS")
> !    (set_attr "type" "floaddf,floaddf,floaddf,fstoredf,fstoredf,lr,load,store,*")])

the lz?r instructions should be classified as fsimp* instead of fload* 
as far as their pipeline behaviour is concerned ...

Could you prepare an updated patch?  Thanks!

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  Linux on zSeries Development
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]