This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] remove -mint64 option for mips


Eric Christopher <echristo@redhat.com> writes:
> We deprecated this in 4.0 and since we've released that we can remove it
> in mainline. Tested by building mipsisa64-elf and making sure that cc1 -
> mint64 fails.

Thanks for doing this.

> 	* doc/invoke.texi (Option Summary): Remove -mint64 for
> 	mips.

You didn't remove the documentation itself though.  There was also
a lingering reference in cp/mangle.c and in a comment above the
implementation of TARGET_SCALAR_MODE_SUPPORTED_P.

WRT to the scalar mode hook: removing -mint64 has also removed
the only reason we needed a MIPS-specific implmentation.  We can
go back to using the standard one now.

Tested on mips64-elf.  Applied to mainline.

Richard


	* doc/invoke.texi: Remove documentation for MIPS' -mint64 option.
	* config/mips/mips.c (TARGET_SCALAR_MODE_SUPPORTED_P): Delete.
	(mips_scalar_mode_supported_p): Delete.

cp/
	* mangle.c: Remove a reference to the MIPS -mint64 option.

Index: doc/invoke.texi
===================================================================
RCS file: /cvs/gcc/gcc/gcc/doc/invoke.texi,v
retrieving revision 1.614
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.614 invoke.texi
*** doc/invoke.texi	6 May 2005 23:41:07 -0000	1.614
--- doc/invoke.texi	7 May 2005 09:46:38 -0000
*************** support to be enabled.
*** 9857,9870 ****
  Use (do not use) the MIPS-3D ASE@.  @xref{MIPS-3D Built-in Functions}.
  The option @option{-mips3d} implies @option{-mpaired-single}.
  
- @item -mint64
- @opindex mint64
- Force @code{int} and @code{long} types to be 64 bits wide.  See
- @option{-mlong32} for an explanation of the default and the way
- that the pointer size is determined.
- 
- This option has been deprecated and will be removed in a future release.
- 
  @item -mlong64
  @opindex mlong64
  Force @code{long} types to be 64 bits wide.  See @option{-mlong32} for
--- 9857,9862 ----
Index: cp/mangle.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cp/mangle.c,v
retrieving revision 1.122
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.122 mangle.c
*** cp/mangle.c	7 May 2005 04:12:06 -0000	1.122
--- cp/mangle.c	7 May 2005 09:46:38 -0000
*************** write_builtin_type (tree type)
*** 1773,1783 ****
  		     type" with a name the form intN or uintN, respectively.
  		     Situations like this can happen if you have an
  		     __attribute__((__mode__(__SI__))) type and use exotic
! 		     switches like '-mint64' on MIPS or '-mint8' on AVR.
! 		     Of course, this is undefined by the C++ ABI (and
! 		     '-mint8' is not even Standard C conforming), but when
! 		     using such special options you're pretty much in nowhere
! 		     land anyway.  */
  		  const char *prefix;
  		  char prec[11];	/* up to ten digits for an unsigned */
  
--- 1773,1782 ----
  		     type" with a name the form intN or uintN, respectively.
  		     Situations like this can happen if you have an
  		     __attribute__((__mode__(__SI__))) type and use exotic
! 		     switches like '-mint8' on AVR.  Of course, this is
! 		     undefined by the C++ ABI (and '-mint8' is not even
! 		     Standard C conforming), but when using such special
! 		     options you're pretty much in nowhere land anyway.  */
  		  const char *prefix;
  		  char prec[11];	/* up to ten digits for an unsigned */
  
Index: config/mips/mips.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/mips/mips.c,v
retrieving revision 1.499
diff -c -p -F^\([(a-zA-Z0-9_]\|#define\) -r1.499 mips.c
*** config/mips/mips.c	6 May 2005 23:41:04 -0000	1.499
--- config/mips/mips.c	7 May 2005 09:46:41 -0000
*************** static bool mips_callee_copies (CUMULATI
*** 357,363 ****
  static int mips_arg_partial_bytes (CUMULATIVE_ARGS *, enum machine_mode mode,
  				   tree, bool);
  static bool mips_valid_pointer_mode (enum machine_mode);
- static bool mips_scalar_mode_supported_p (enum machine_mode);
  static bool mips_vector_mode_supported_p (enum machine_mode);
  static rtx mips_prepare_builtin_arg (enum insn_code, unsigned int, tree *);
  static rtx mips_prepare_builtin_target (enum insn_code, unsigned int, rtx);
--- 357,362 ----
*************** #define TARGET_ARG_PARTIAL_BYTES mips_ar
*** 820,828 ****
  #undef TARGET_VECTOR_MODE_SUPPORTED_P
  #define TARGET_VECTOR_MODE_SUPPORTED_P mips_vector_mode_supported_p
  
- #undef TARGET_SCALAR_MODE_SUPPORTED_P
- #define TARGET_SCALAR_MODE_SUPPORTED_P mips_scalar_mode_supported_p
- 
  #undef TARGET_INIT_BUILTINS
  #define TARGET_INIT_BUILTINS mips_init_builtins
  #undef TARGET_EXPAND_BUILTIN
--- 819,824 ----
*************** mips_valid_pointer_mode (enum machine_mo
*** 7285,7328 ****
    return (mode == SImode || (TARGET_64BIT && mode == DImode));
  }
  
- /* Define this so that we can deal with a testcase like:
- 
-    char foo __attribute__ ((mode (SI)));
- 
-    then compiled with -mabi=64 and -mint64. We have no
-    32-bit type at that point and so the default case
-    always fails.  */
- 
- static bool
- mips_scalar_mode_supported_p (enum machine_mode mode)
- {
-   switch (mode)
-     {
-     case QImode:
-     case HImode:
-     case SImode:
-     case DImode:
-       return true;
- 
-       /* Handled via optabs.c.  */
-     case TImode:
-       return TARGET_64BIT;
- 
-     case SFmode:
-     case DFmode:
-       return true;
- 
-       /* LONG_DOUBLE_TYPE_SIZE is 128 for TARGET_NEWABI only.  */
-     case TFmode:
-       return TARGET_NEWABI;
- 
-     default:
-       return false;
-     }
- }
- 
- 
  /* Target hook for vector_mode_supported_p.  */
  static bool
  mips_vector_mode_supported_p (enum machine_mode mode)
  {
--- 7281,7288 ----
    return (mode == SImode || (TARGET_64BIT && mode == DImode));
  }
  
  /* Target hook for vector_mode_supported_p.  */
+ 
  static bool
  mips_vector_mode_supported_p (enum machine_mode mode)
  {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]