Re: [PATCH] Don't use .gnu.linkonce with COMDAT

[Mark Mitchell <mark at codesourcery dot com>]

Julian Brown wrote:
> Mark Mitchell wrote:
>
> > Daniel Jacobowitz wrote:
> >
> > > How does this patch interact with non-GNU linkers?  This is one of the
> > > problems with version-number based checks...
> >
> >
> >
> > All the ld_vers* stuff is conditionalized on GNU ld, so I think this 
> > patch would disable COMDAT for non-GNU linkers.  Julian, I suggest you 
> > change it so that if $ld_vers is empty, you just set HAVE_COMDAT_GROUP 
> > based on the the assembler, as is done at present.  That's no more or 
> > less broken than the current state.
>
>
> I think this is done anyway with the patch as-is:
>
>   ... && test x"$ld_vers" != x; then ...

I see, you're correct.  Thanks!

> I've rewritten this bit to use strcpy/strcat, and it is much clearer 
> now.

Yes, much better.  If you really want to go nuts, you could even do:

  sprintf (rname, "%s.rodata", name);

But, I think what you've got is clear enough.

> I'll wait a day or so before applying this though, I think, in case 
> anyone notices or predicts any further problems. 

Great, thanks.

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304