This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: assertify mn10300
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: 06 May 2005 17:17:11 -0300
- Subject: Re: assertify mn10300
- References: <427B8DAC.9080909@codesourcery.com>
On May 6, 2005, Nathan Sidwell <nathan@codesourcery.com> wrote:
> This patch assertifies the mn10300 target. tested with an i686 hosted
> cross tools and simulated thereon. ok?
Looks good, thanks!
I'm just a bit concerned about some of the changes from
`if (expr) abort ();' to `gcc_assert (expr);', since they change the
meaning of the program if checking is disabled, and in some cases
could result in incorrect being generated, instead of an ICE. I'm
assuming such changes were thought-out and intentional, so go for it.
> 2005-05-06 Nathan Sidwell <nathan@codesourcery.com>
> * config/mn10300/mn10300.c (print_operand): Use gcc_assert and
> gcc_unreachable as appropriate.
> (print_operand_address, mn10300_print_reg_list, expand_prologue,
> expand_epilogue, notice_update_cc, initial_offset,
> mn10300_address_cost_1): Likewise.
> * config/mn10300/mn10300.md: Likewise.
> (absdf2, abssf2, negdf2, negsf2): Likewise.
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}